rtl8712: don't just return -EFAULT in wpa_supplicant_ioctl()
authorDan Carpenter <error27@gmail.com>
Sat, 6 Aug 2011 14:27:48 +0000 (07:27 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 23 Aug 2011 22:16:35 +0000 (15:16 -0700)
There were some curly braces missing so the original code in
wpa_supplicant_ioctl() pretty much always returned -EFAULT without
doing anything.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/rtl8712/rtl871x_ioctl_linux.c

index 59bdab105334ea700c0a3cc9cb40e9367aa73b50..d310a6174b97abbfcc9304e133862cd8643f8f80 100644 (file)
@@ -2089,9 +2089,10 @@ static int wpa_supplicant_ioctl(struct net_device *dev, struct iw_point *p)
        param = (struct ieee_param *)_malloc(p->length);
        if (param == NULL)
                return -ENOMEM;
-       if (copy_from_user(param, p->pointer, p->length))
+       if (copy_from_user(param, p->pointer, p->length)) {
                kfree((u8 *)param);
                return -EFAULT;
+       }
        switch (param->cmd) {
        case IEEE_CMD_SET_WPA_PARAM:
                ret = wpa_set_param(dev, param->u.wpa_param.name,