spi: a3700: Return correct value on timeout detection
authorMaxime Chevallier <maxime.chevallier@smile.fr>
Tue, 10 Oct 2017 08:43:17 +0000 (10:43 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 10 Oct 2017 09:14:32 +0000 (10:14 +0100)
When waiting for transfer completion, a3700_spi_wait_completion
returns a boolean indicating if a timeout occurred.

The function was returning 'true' everytime, failing to detect any
timeout.

This patch makes it return 'false' when a timeout is reached.

Signed-off-by: Maxime Chevallier <maxime.chevallier@smile.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
drivers/spi/spi-armada-3700.c

index 9172cb2d2e7a96822b261f0175527eb52110f887..568e1c65aa82cb77a92b7df5ff066513c3d959a8 100644 (file)
@@ -387,7 +387,8 @@ static bool a3700_spi_wait_completion(struct spi_device *spi)
 
        spireg_write(a3700_spi, A3700_SPI_INT_MASK_REG, 0);
 
-       return true;
+       /* Timeout was reached */
+       return false;
 }
 
 static bool a3700_spi_transfer_wait(struct spi_device *spi,