iwlwifi: mvm: remove unneeded reg write in iwl_mvm_up()
authorLiad Kaufman <liad.kaufman@intel.com>
Wed, 1 Feb 2017 14:21:32 +0000 (16:21 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Wed, 19 Apr 2017 19:21:47 +0000 (22:21 +0300)
Not only that this write is not needed (as FW does this
itself), on newer HW this register is write protected
so trying to write there will cause problems.

Signed-off-by: Liad Kaufman <liad.kaufman@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-prph.h
drivers/net/wireless/intel/iwlwifi/mvm/fw.c

index e1aa1f7836fc161858b545d575b00186d9f8b13d..4bceaccee62f324a4d5006fdd0ab6cd741654cd2 100644 (file)
 
 /*********************** END TX SCHEDULER *************************************/
 
-/* tcp checksum offload */
-#define RX_EN_CSUM             (0x00a00d88)
-
 /* Oscillator clock */
 #define OSC_CLK                                (0xa04068)
 #define OSC_CLK_FORCE_CONTROL          (0x8)
index 2a4c952ef01a5e2f158e14f272d37cebfcd01ee6..bfccbadd1a6ec14a32a9f14ad96db61013d5ca80 100644 (file)
@@ -1475,10 +1475,6 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
                        goto error;
        }
 
-       if (iwl_mvm_is_csum_supported(mvm) &&
-           mvm->cfg->features & NETIF_F_RXCSUM)
-               iwl_trans_write_prph(mvm->trans, RX_EN_CSUM, 0x3);
-
        /* allow FW/transport low power modes if not during restart */
        if (!test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status))
                iwl_mvm_unref(mvm, IWL_MVM_REF_UCODE_DOWN);