projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 5ea7509)
usb: dwc2: gadget: use | instead of + for bitmasks
authorFelipe Balbi <balbi@ti.com>
Tue, 30 Jun 2015 01:17:22 +0000 (20:17 -0500)
committerFelipe Balbi <balbi@ti.com>
Wed, 29 Jul 2015 14:59:17 +0000 (09:59 -0500)
It's just a lot clearer to use | operator instead of
+ operator.

Caught by coccicheck:

"
drivers/usb/dwc2/gadget.c:2883:26-27: WARNING: sum of probable
bitmasks, consider |
"

Cc: John Youn <John.Youn@synopsys.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc2/gadget.c patch | blob | blame | history

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 4d47b7c092387fbbf672d9fb5b536ad94633a57c..731b13dfc512d6ca3ca66f5bfd586440e312ef11 100644 (file)
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -2880,7 +2880,7 @@ static int s3c_hsotg_ep_sethalt(struct usb_ep *ep, int value)
                epctl = readl(hs->regs + epreg);
 
                if (value) {
-                       epctl |= DXEPCTL_STALL + DXEPCTL_SNAK;
+                       epctl |= DXEPCTL_STALL | DXEPCTL_SNAK;
                        if (epctl & DXEPCTL_EPENA)
                                epctl |= DXEPCTL_EPDIS;
                } else {