drm/rockchip: return ERR_PTR instead of NULL
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 10 Nov 2016 21:10:56 +0000 (22:10 +0100)
committerMark Yao <mark.yao@rock-chips.com>
Sun, 5 Feb 2017 08:19:11 +0000 (16:19 +0800)
rockchip_drm_framebuffer_init is only used in one case, in
rockchip_drm_fbdev.c, where its return value is tested using IS_ERR.  To
enable propagating the reason for the error, change the definition so that
it returns an ERR_PTR value.

Problem found with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
drivers/gpu/drm/rockchip/rockchip_drm_fb.c

index d5e1f8627d3864bdc4c0f7fbba869def8bf1fe3d..c9ccdf8f44bb2ba6ad049985b805f462d4a38af6 100644 (file)
@@ -213,7 +213,7 @@ rockchip_drm_framebuffer_init(struct drm_device *dev,
 
        rockchip_fb = rockchip_fb_alloc(dev, mode_cmd, &obj, 1);
        if (IS_ERR(rockchip_fb))
-               return NULL;
+               return ERR_CAST(rockchip_fb);
 
        return &rockchip_fb->fb;
 }