RDS: use kfree_rcu in rds_ib_remove_ipaddr
authorSantosh Shilimkar <santosh.shilimkar@oracle.com>
Fri, 3 Feb 2012 16:09:23 +0000 (11:09 -0500)
committerSantosh Shilimkar <ssantosh@kernel.org>
Wed, 30 Sep 2015 16:43:24 +0000 (12:43 -0400)
synchronize_rcu() slowing down un-necessarily the socket shutdown
path. It is used just kfree() the ip addresses in rds_ib_remove_ipaddr()
which is perfect usecase for kfree_rcu();

So lets use that to gain some speedup.

Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
net/rds/ib.h
net/rds/ib_rdma.c

index aae60fda77f6d26d033a8c8b1fdb808eb6effaa0..f1fd5ffec4e1e39be1e5f80b83b05553be0e75c4 100644 (file)
@@ -164,6 +164,7 @@ struct rds_ib_connection {
 struct rds_ib_ipaddr {
        struct list_head        list;
        __be32                  ipaddr;
+       struct rcu_head         rcu;
 };
 
 struct rds_ib_device {
index 251d1ce0b7c7a0da22fc445e778b2078559168f4..872f523630f29e2ecbfd83b7fd17ea3134346071 100644 (file)
@@ -159,10 +159,8 @@ static void rds_ib_remove_ipaddr(struct rds_ib_device *rds_ibdev, __be32 ipaddr)
        }
        spin_unlock_irq(&rds_ibdev->spinlock);
 
-       if (to_free) {
-               synchronize_rcu();
-               kfree(to_free);
-       }
+       if (to_free)
+               kfree_rcu(to_free, rcu);
 }
 
 int rds_ib_update_ipaddr(struct rds_ib_device *rds_ibdev, __be32 ipaddr)