fpga: altera-pr-ip: fix unsigned comparison with less than zero
authorMarco Pagani <marpagan@redhat.com>
Thu, 9 Jun 2022 14:05:19 +0000 (16:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:11:21 +0000 (11:11 +0200)
[ Upstream commit 2df84a757d87fd62869fc401119d429735377ec5 ]

Fix the "comparison with less than zero" warning reported by
cppcheck for the unsigned (size_t) parameter count of the
alt_pr_fpga_write() function.

Fixes: d201cc17a8a3 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP")
Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Marco Pagani <marpagan@redhat.com>
Link: https://lore.kernel.org/r/20220609140520.42662-1-marpagan@redhat.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/fpga/altera-pr-ip-core.c

index a7b31f9797ce180daa0e0cf91b69424300556626..0314737d705b419a8ded39bef498418c552a650a 100644 (file)
@@ -119,7 +119,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
        u32 *buffer_32 = (u32 *)buf;
        size_t i = 0;
 
-       if (count <= 0)
+       if (!count)
                return -EINVAL;
 
        /* Write out the complete 32-bit chunks */