mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages

[ Upstream commit a75bbe71a27875fdc61cde1af6d799037cef6bed ]

Per ONFI specification (Rev. 4.0), if the CRC of the first parameter page
read is not valid, the host should read redundant parameter page copies.
Fix FSL NAND driver to read the two redundant copies which are mandatory
in the specification.

Signed-off-by: Jane Wan <Jane.Wan@nokia.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index 4005b427023c31f48a562494a8a3258135e362b0..16deba1a2385876ae8002eab2c6df14f1294a576 100644 (file)
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -342,9 +342,16 @@ static void fsl_ifc_cmdfunc(struct mtd_info *mtd, unsigned int command,
 
        case NAND_CMD_READID:
        case NAND_CMD_PARAM: {
+               /*
+                * For READID, read 8 bytes that are currently used.
+                * For PARAM, read all 3 copies of 256-bytes pages.
+                */
+               int len = 8;
                int timing = IFC_FIR_OP_RB;
-               if (command == NAND_CMD_PARAM)
+               if (command == NAND_CMD_PARAM) {
                        timing = IFC_FIR_OP_RBCD;
+                       len = 256 * 3;
+               }
 
                ifc_out32((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) |
                          (IFC_FIR_OP_UA  << IFC_NAND_FIR0_OP1_SHIFT) |
@@ -354,12 +361,8 @@ static void fsl_ifc_cmdfunc(struct mtd_info *mtd, unsigned int command,
                          &ifc->ifc_nand.nand_fcr0);
                ifc_out32(column, &ifc->ifc_nand.row3);
 
-               /*
-                * although currently it's 8 bytes for READID, we always read
-                * the maximum 256 bytes(for PARAM)
-                */
-               ifc_out32(256, &ifc->ifc_nand.nand_fbcr);
-               ifc_nand_ctrl->read_bytes = 256;
+               ifc_out32(len, &ifc->ifc_nand.nand_fbcr);
+               ifc_nand_ctrl->read_bytes = len;
 
                set_addr(mtd, 0, 0, 0);
                fsl_ifc_run_command(mtd);