[CIFS] Fix incorrect hex vs. decimal in some debug print statements
authorSteve French <smfrench@gmail.com>
Sun, 3 Aug 2014 02:16:48 +0000 (21:16 -0500)
committerSteve French <smfrench@gmail.com>
Sun, 3 Aug 2014 02:16:48 +0000 (21:16 -0500)
Joe Perches and Hans Wennborg noticed that various places in the
kernel were printing decimal numbers with 0x prefix.
    printk("0x%d") or equivalent
This fixes the instances of this in the cifs driver.

CC: Hans Wennborg <hans@hanshq.net>
CC: Joe Perches <joe@perches.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/cifs_debug.c
fs/cifs/misc.c
fs/cifs/smb2misc.c

index f3ac4154cbb606707956d9fbbd2a64ec553a9ceb..44ec72684df592bce09b24c6e5ecf65fb0b5fff8 100644 (file)
@@ -213,7 +213,7 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
                                                   tcon->nativeFileSystem);
                                }
                                seq_printf(m, "DevInfo: 0x%x Attributes: 0x%x"
-                                       "\n\tPathComponentMax: %d Status: 0x%d",
+                                       "\n\tPathComponentMax: %d Status: %d",
                                        le32_to_cpu(tcon->fsDevInfo.DeviceCharacteristics),
                                        le32_to_cpu(tcon->fsAttrInfo.Attributes),
                                        le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength),
index 64997a04ab59020326dc4481791f80d882eda82d..e65e17b3d484a9872c56b5a7d63836e7fba0d874 100644 (file)
@@ -423,7 +423,7 @@ is_valid_oplock_break(char *buffer, struct TCP_Server_Info *srv)
                        return true;
                }
                if (pSMBr->hdr.Status.CifsError) {
-                       cifs_dbg(FYI, "notify err 0x%d\n",
+                       cifs_dbg(FYI, "notify err 0x%x\n",
                                 pSMBr->hdr.Status.CifsError);
                        return true;
                }
@@ -450,7 +450,7 @@ is_valid_oplock_break(char *buffer, struct TCP_Server_Info *srv)
        if (pSMB->hdr.WordCount != 8)
                return false;
 
-       cifs_dbg(FYI, "oplock type 0x%d level 0x%d\n",
+       cifs_dbg(FYI, "oplock type 0x%x level 0x%x\n",
                 pSMB->LockType, pSMB->OplockLevel);
        if (!(pSMB->LockType & LOCKING_ANDX_OPLOCK_RELEASE))
                return false;
index b8021fde987dbbe65dbb6c09fd98e715521187c0..f2e6ac29a8d661b82f4ba1712dee36a842d6f7cd 100644 (file)
@@ -437,7 +437,7 @@ smb2_tcon_has_lease(struct cifs_tcon *tcon, struct smb2_lease_break *rsp,
                        continue;
 
                cifs_dbg(FYI, "found in the open list\n");
-               cifs_dbg(FYI, "lease key match, lease break 0x%d\n",
+               cifs_dbg(FYI, "lease key match, lease break 0x%x\n",
                         le32_to_cpu(rsp->NewLeaseState));
 
                server->ops->set_oplock_level(cinode, lease_state, 0, NULL);
@@ -467,7 +467,7 @@ smb2_tcon_has_lease(struct cifs_tcon *tcon, struct smb2_lease_break *rsp,
                }
 
                cifs_dbg(FYI, "found in the pending open list\n");
-               cifs_dbg(FYI, "lease key match, lease break 0x%d\n",
+               cifs_dbg(FYI, "lease key match, lease break 0x%x\n",
                         le32_to_cpu(rsp->NewLeaseState));
 
                open->oplock = lease_state;
@@ -546,7 +546,7 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server)
                        return false;
        }
 
-       cifs_dbg(FYI, "oplock level 0x%d\n", rsp->OplockLevel);
+       cifs_dbg(FYI, "oplock level 0x%x\n", rsp->OplockLevel);
 
        /* look up tcon based on tid & uid */
        spin_lock(&cifs_tcp_ses_lock);