crypto: omap-des - fix error return code in omap_des_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 15 Sep 2016 03:27:15 +0000 (03:27 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 22 Sep 2016 10:27:34 +0000 (18:27 +0800)
Fix to return error code -ENOMEM from the crypto_engine_alloc_init()
error handling case instead of 0, as done elsewhere in this function.

Fixes: f1b77aaca85a ("crypto: omap-des - Integrate with the crypto
engine framework")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-des.c

index 2b20d960caa87065a391ada2b0036b6cf1bf7b30..a6f65532fd167d054930c9e89384c54337d3429e 100644 (file)
@@ -1081,8 +1081,10 @@ static int omap_des_probe(struct platform_device *pdev)
 
        /* Initialize des crypto engine */
        dd->engine = crypto_engine_alloc_init(dev, 1);
-       if (!dd->engine)
+       if (!dd->engine) {
+               err = -ENOMEM;
                goto err_engine;
+       }
 
        dd->engine->prepare_cipher_request = omap_des_prepare_req;
        dd->engine->cipher_one_request = omap_des_crypt_req;