staging: sync: fix return value check in sync_fence_alloc()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Mon, 11 Mar 2013 13:45:34 +0000 (21:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 11 Mar 2013 17:14:35 +0000 (10:14 -0700)
In case of error, the function anon_inode_getfile() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/sync.c

index b9bb974faacdf0db64d5cfec9011a3f5cac204e8..bf66c199a8335c1bdcfa00a7fbebafd76dcc722c 100644 (file)
@@ -261,7 +261,7 @@ static struct sync_fence *sync_fence_alloc(const char *name)
 
        fence->file = anon_inode_getfile("sync_fence", &sync_fence_fops,
                                         fence, 0);
-       if (fence->file == NULL)
+       if (IS_ERR(fence->file))
                goto err;
 
        kref_init(&fence->kref);