media: omap3isp: Ignore endpoints with invalid configuration

If endpoint has an invalid configuration, ignore it instead of happily
proceeding to use it nonetheless. Ignoring such an endpoint is better than
failing since there could be multiple endpoints, only some of which are
bad.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index dbaede0d8974755f43cf17eab189cedfa13a6e5e..2de7a27bb0e5edf83f68731fed4e2a5e3168c44c 100644 (file)
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2111,10 +2111,12 @@ static int isp_fwnodes_parse(struct device *dev,
                if (!isd)
                        goto error;
 
-               notifier->subdevs[notifier->num_subdevs] = &isd->asd;
+               if (isp_fwnode_parse(dev, fwnode, isd)) {
+                       devm_kfree(dev, isd);
+                       continue;
+               }
 
-               if (isp_fwnode_parse(dev, fwnode, isd))
-                       goto error;
+               notifier->subdevs[notifier->num_subdevs] = &isd->asd;
 
                isd->asd.match.fwnode.fwnode =
                        fwnode_graph_get_remote_port_parent(fwnode);