projects
/
GitHub
/
MotorolaMobilityLLC
/
kernel-slsi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
53ab222
)
rds: Lost locking in loop connection freeing
author
Pavel Emelyanov
<xemul@parallels.com>
Tue, 2 Nov 2010 01:52:05 +0000
(
01:52
+0000)
committer
David S. Miller
<davem@davemloft.net>
Thu, 4 Nov 2010 01:50:06 +0000
(18:50 -0700)
The conn is removed from list in there and this requires
proper lock protection.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/loop.c
patch
|
blob
|
blame
|
history
diff --git
a/net/rds/loop.c
b/net/rds/loop.c
index c390156b426fc936c6b05fd607f4c32ddb1e3a81..aeec1d483b17e6f65c858e1510c7752965e35260 100644
(file)
--- a/
net/rds/loop.c
+++ b/
net/rds/loop.c
@@
-134,8
+134,12
@@
static int rds_loop_conn_alloc(struct rds_connection *conn, gfp_t gfp)
static void rds_loop_conn_free(void *arg)
{
struct rds_loop_connection *lc = arg;
+ unsigned long flags;
+
rdsdebug("lc %p\n", lc);
+ spin_lock_irqsave(&loop_conns_lock, flags);
list_del(&lc->loop_node);
+ spin_unlock_irqrestore(&loop_conns_lock, flags);
kfree(lc);
}