usb: gadget: Use kmemdup instead of kmalloc + memcpy

This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index 2ddcd635ca2abccb9b559adeb4dd2a74c26a0d06..bcc2a6248187fd58693d45075c6dde314a6bb545 100644 (file)
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -1021,12 +1021,10 @@ static ssize_t ext_prop_data_store(struct usb_os_desc_ext_prop *ext_prop,
 
        if (page[len - 1] == '\n' || page[len - 1] == '\0')
                --len;
-       new_data = kzalloc(len, GFP_KERNEL);
+       new_data = kmemdup(page, len, GFP_KERNEL);
        if (!new_data)
                return -ENOMEM;
 
-       memcpy(new_data, page, len);
-
        if (desc->opts_mutex)
                mutex_lock(desc->opts_mutex);
        kfree(ext_prop->data);

diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
index c77c6872b3efffa3ea57275b24b6afa14741e986..a93f64b9e632f1626fbd46bdba992bbd1705b55a 100644 (file)
--- a/drivers/usb/gadget/lpc32xx_udc.c
+++ b/drivers/usb/gadget/lpc32xx_udc.c
@@ -3045,11 +3045,10 @@ static int __init lpc32xx_udc_probe(struct platform_device *pdev)
        dma_addr_t dma_handle;
        struct device_node *isp1301_node;
 
-       udc = kzalloc(sizeof(*udc), GFP_KERNEL);
+       udc = kmemdup(&controller_template, sizeof(*udc), GFP_KERNEL);
        if (!udc)
                return -ENOMEM;
 
-       memcpy(udc, &controller_template, sizeof(*udc));
        for (i = 0; i <= 15; i++)
                udc->ep[i].udc = udc;
        udc->gadget.ep0 = &udc->ep[0].ep;