drm/radeon: remove unecessary assignment
authorIlija Hadzic <ihadzic@research.bell-labs.com>
Wed, 2 Jan 2013 23:27:37 +0000 (18:27 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 31 Jan 2013 21:24:39 +0000 (16:24 -0500)
length_dw field was assigned twice. While at it, move user_ptr
assignment together with all other assignments to p->chunks[i]
structure to make the code more readable.

Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Reviewed-by: Marek Olšák <maraeo@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_cs.c

index 5407459e56d2b5dd9619e698c2ec306c56104f4a..56f9282b327975214bb979811ea199e55bec2e45 100644 (file)
@@ -203,7 +203,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
                p->chunks[i].length_dw = user_chunk.length_dw;
                p->chunks[i].kdata = NULL;
                p->chunks[i].chunk_id = user_chunk.chunk_id;
-
+               p->chunks[i].user_ptr = (void __user *)(unsigned long)user_chunk.chunk_data;
                if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_RELOCS) {
                        p->chunk_relocs_idx = i;
                }
@@ -226,9 +226,6 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
                                return -EINVAL;
                }
 
-               p->chunks[i].length_dw = user_chunk.length_dw;
-               p->chunks[i].user_ptr = (void __user *)(unsigned long)user_chunk.chunk_data;
-
                cdata = (uint32_t *)(unsigned long)user_chunk.chunk_data;
                if ((p->chunks[i].chunk_id == RADEON_CHUNK_ID_RELOCS) ||
                    (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS)) {