sfc: don't warn on successful change of MAC
authorRobert Stonehouse <rstonehouse@solarflare.com>
Tue, 7 Nov 2017 17:30:30 +0000 (17:30 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2017 09:04:57 +0000 (10:04 +0100)
[ Upstream commit cbad52e92ad7f01f0be4ca58bde59462dc1afe3a ]

Fixes: 535a61777f44e ("sfc: suppress handled MCDI failures when changing the MAC address")
Signed-off-by: Bert Kenward <bkenward@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/sfc/ef10.c

index cbe9a330117a1133231518d2f66d5d3826fef8bc..063aca17e698b40cb1ce598a52ce24bc24306731 100644 (file)
@@ -4307,7 +4307,7 @@ static int efx_ef10_set_mac_address(struct efx_nic *efx)
                 * MCFW do not support VFs.
                 */
                rc = efx_ef10_vport_set_mac_address(efx);
-       } else {
+       } else if (rc) {
                efx_mcdi_display_error(efx, MC_CMD_VADAPTOR_SET_MAC,
                                       sizeof(inbuf), NULL, 0, rc);
        }