packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode
authorDaniel Borkmann <daniel@iogearbox.net>
Thu, 5 Jan 2017 01:34:28 +0000 (02:34 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Jan 2017 04:55:42 +0000 (23:55 -0500)
When TX timestamping is in use with TPACKET_V3's TX ring, then we'll
hit the BUG() in __packet_set_timestamp() when ring buffer slot is
returned to user space via tpacket_destruct_skb(). This is due to v3
being assumed as unreachable here, but since 7f953ab2ba46 ("af_packet:
TX_RING support for TPACKET_V3") it's not anymore. Fix it by filling
the timestamp back into the ring slot.

Fixes: 7f953ab2ba46 ("af_packet: TX_RING support for TPACKET_V3")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c

index 7e39087d519b85105077ec265cbcf4c2ef906938..ddbda255b6ae47c816522244ddcdbbd1aac2db00 100644 (file)
@@ -481,6 +481,9 @@ static __u32 __packet_set_timestamp(struct packet_sock *po, void *frame,
                h.h2->tp_nsec = ts.tv_nsec;
                break;
        case TPACKET_V3:
+               h.h3->tp_sec = ts.tv_sec;
+               h.h3->tp_nsec = ts.tv_nsec;
+               break;
        default:
                WARN(1, "TPACKET version not supported.\n");
                BUG();