Input: cyttsp4 - kfree xfer_buf on error path in probe()
authorFerruh Yigit <fery@cypress.com>
Thu, 4 Jul 2013 21:02:45 +0000 (14:02 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 4 Jul 2013 21:05:50 +0000 (14:05 -0700)
If probe() fails after cd->xfer_buf allocated, it will not freed.
Added kfree(cd->xfer_buf) with and error label.

Signed-off-by: Ferruh Yigit <fery@cypress.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/cyttsp4_core.c

index a7987e170071a533a450512ba7d21e723ba066c6..edcf7993034bc390ffe6d34c6b129ae4afd79292 100644 (file)
@@ -2049,7 +2049,7 @@ struct cyttsp4 *cyttsp4_probe(const struct cyttsp4_bus_ops *ops,
        cd->irq = gpio_to_irq(cd->cpdata->irq_gpio);
        if (cd->irq < 0) {
                rc = -EINVAL;
-               goto error_free_cd;
+               goto error_free_xfer;
        }
 
        dev_set_drvdata(dev, cd);
@@ -2117,6 +2117,8 @@ error_request_irq:
        if (cd->cpdata->init)
                cd->cpdata->init(cd->cpdata, 0, dev);
        dev_set_drvdata(dev, NULL);
+error_free_xfer:
+       kfree(cd->xfer_buf);
 error_free_cd:
        kfree(cd);
 error_alloc_data: