[SCSI] scsi_dh_emc: request flag cleanup
authorMike Christie <michaelc@cs.wisc.edu>
Sat, 10 Apr 2010 03:07:37 +0000 (22:07 -0500)
committerJames Bottomley <James.Bottomley@suse.de>
Sun, 11 Apr 2010 19:04:02 +0000 (14:04 -0500)
blk_get_request sets the cmd_flags, so we should not and do not
need to set them. If we did set them to a different value then
it can cause a oops in the elevator code.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/device_handler/scsi_dh_emc.c

index e8a0bc3efd491a91d212233e46c3b29f94498967..6faf472f7537a4b728d2947ea69647c0a724b14d 100644 (file)
@@ -285,13 +285,11 @@ static struct request *get_req(struct scsi_device *sdev, int cmd,
        switch (cmd) {
        case MODE_SELECT:
                len = sizeof(short_trespass);
-               rq->cmd_flags |= REQ_RW;
                rq->cmd[1] = 0x10;
                rq->cmd[4] = len;
                break;
        case MODE_SELECT_10:
                len = sizeof(long_trespass);
-               rq->cmd_flags |= REQ_RW;
                rq->cmd[1] = 0x10;
                rq->cmd[8] = len;
                break;