USB: remove iteration limit in hub_tt_work()
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 31 Oct 2012 17:09:07 +0000 (13:09 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Oct 2012 19:48:07 +0000 (12:48 -0700)
This patch (as1621) removes the limit on the number of loops allowed
in hub_tt_work().  The value is arbitrary, and it's silly to have a
limit in the first place -- anything beyond the limit would not get
handled.

Besides, it's most unlikely that we'll ever need to clear more than a
couple of TT buffers at any time.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c

index fbaf3c3dbf0751e6a083d8ce27fd91b0bb795aba..90accdefdc7db657c4ad5eff12c2d248e11cf31d 100644 (file)
@@ -741,7 +741,6 @@ static void hub_tt_work(struct work_struct *work)
        struct usb_hub          *hub =
                container_of(work, struct usb_hub, tt.clear_work);
        unsigned long           flags;
-       int                     limit = 100;
 
        spin_lock_irqsave (&hub->tt.lock, flags);
        while (!list_empty(&hub->tt.clear_list)) {
@@ -751,9 +750,6 @@ static void hub_tt_work(struct work_struct *work)
                const struct hc_driver  *drv;
                int                     status;
 
-               if (!hub->quiescing && --limit < 0)
-                       break;
-
                next = hub->tt.clear_list.next;
                clear = list_entry (next, struct usb_tt_clear, clear_list);
                list_del (&clear->clear_list);