USB: gadget: ci13xx_pci: remove unneeded check in ci13xxx_pci_probe()
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 May 2012 18:41:49 +0000 (11:41 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 May 2012 18:41:49 +0000 (11:41 -0700)
As pointed out by Dan Carpenter, the check for NULL for the id variable
is no longer needed, especially as we just dereferenced it a few lines
earlier, causing an oops if it really was NULL.

This was caused by 62bb84ed0e4d: "usb: gadget: ci13xxx: convert to
platform device".

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/ci13xxx_pci.c

index ea03fabd4d970a2022bc673974fd35b0578a2f12..c76844110e36f857cc321d97a9ffaff20a4c8f2e 100644 (file)
@@ -51,9 +51,6 @@ static int __devinit ci13xxx_pci_probe(struct pci_dev *pdev,
        struct resource res[3];
        int retval = 0, nres = 2;
 
-       if (id == NULL)
-               return -EINVAL;
-
        retval = pci_enable_device(pdev);
        if (retval)
                goto done;