[SCSI] fcoe: fix incorrect use of struct module
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Mon, 29 Dec 2008 21:45:41 +0000 (15:45 -0600)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Tue, 30 Dec 2008 19:08:37 +0000 (13:08 -0600)
This structure may not be defined if CONFIG_MODULE=n, so never deref
it.  Change uses of module->name to module_name(module) and corrects
some dyslexic printks and docbook comments.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/fcoe/libfcoe.c

index 1cb549c4fac4a60eb87c988efe269252806bbd92..e419f486cdb333ab53cf693209a251378093b943 100644 (file)
@@ -166,7 +166,7 @@ static int fcoe_cpu_callback(struct notifier_block *nfb, unsigned long action,
 #endif /* CONFIG_HOTPLUG_CPU */
 
 /**
- * foce_rcv - this is the fcoe receive function called by NET_RX_SOFTIRQ
+ * fcoe_rcv - this is the fcoe receive function called by NET_RX_SOFTIRQ
  * @skb: the receive skb
  * @dev: associated net device
  * @ptype: context
@@ -991,8 +991,8 @@ static int fcoe_ethdrv_get(const struct net_device *netdev)
 
        owner = fcoe_netdev_to_module_owner(netdev);
        if (owner) {
-               printk(KERN_DEBUG "foce:hold driver module %s for %s\n",
-                      owner->name, netdev->name);
+               printk(KERN_DEBUG "fcoe:hold driver module %s for %s\n",
+                      module_name(owner), netdev->name);
                return  try_module_get(owner);
        }
        return -ENODEV;
@@ -1011,8 +1011,8 @@ static int fcoe_ethdrv_put(const struct net_device *netdev)
 
        owner = fcoe_netdev_to_module_owner(netdev);
        if (owner) {
-               printk(KERN_DEBUG "foce:release driver module %s for %s\n",
-                      owner->name, netdev->name);
+               printk(KERN_DEBUG "fcoe:release driver module %s for %s\n",
+                      module_name(owner), netdev->name);
                module_put(owner);
                return 0;
        }