NFS: Clean up nfs4_callback_layoutrecall()
authorAnna Schumaker <Anna.Schumaker@Netapp.com>
Fri, 7 Apr 2017 18:14:56 +0000 (14:14 -0400)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Thu, 20 Apr 2017 17:39:32 +0000 (13:39 -0400)
In addition to removing the dprintk(), this patch also initializes "res"
to the default return value instead of doing this through an else
condition.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
fs/nfs/callback_proc.c

index c524080557215bcc54e423a2ed255db4c31d646e..e61e4ccc181a9d68cc5aad753f53549157039e2a 100644 (file)
@@ -325,16 +325,10 @@ static u32 do_callback_layoutrecall(struct nfs_client *clp,
 __be32 nfs4_callback_layoutrecall(struct cb_layoutrecallargs *args,
                                  void *dummy, struct cb_process_state *cps)
 {
-       u32 res;
-
-       dprintk("%s: -->\n", __func__);
+       u32 res = NFS4ERR_OP_NOT_IN_SESSION;
 
        if (cps->clp)
                res = do_callback_layoutrecall(cps->clp, args);
-       else
-               res = NFS4ERR_OP_NOT_IN_SESSION;
-
-       dprintk("%s: exit with status = %d\n", __func__, res);
        return cpu_to_be32(res);
 }