IB/qib: Remove empty function
authorLeon Romanovsky <leon@kernel.org>
Wed, 18 Jan 2017 05:57:58 +0000 (07:57 +0200)
committerDoug Ledford <dledford@redhat.com>
Tue, 24 Jan 2017 21:20:37 +0000 (16:20 -0500)
Commit f06267104dd9 ("RDMA: Update workqueue usage") removed
content of qib_qsfp_deinit(...) and left it empty.

This patch deletes all leftovers of that function.

Signed-off-by: Leon Romanovsky <leon@kernel.org>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/qib/qib_iba7322.c
drivers/infiniband/hw/qib/qib_qsfp.c
drivers/infiniband/hw/qib/qib_qsfp.h

index c4a3616062f16c2c71e34bdfc639f7f05bff5a0f..9cc97bd4277590bf4bc03e58817c4c67adcbb3be 100644 (file)
@@ -2893,7 +2893,6 @@ static void qib_setup_7322_cleanup(struct qib_devdata *dd)
                        dd->cspec->gpio_mask &= ~mask;
                        qib_write_kreg(dd, kr_gpio_mask, dd->cspec->gpio_mask);
                        spin_unlock_irqrestore(&dd->cspec->gpio_lock, flags);
-                       qib_qsfp_deinit(&dd->pport[i].cpspec->qsfp_data);
                }
        }
 }
index 4c7c3c84a7417c32f2f348f7c91c2ce0e4b4e1b0..295d40a83bb626acb0c690152faa5420c5fe8f80 100644 (file)
@@ -485,16 +485,6 @@ void qib_qsfp_init(struct qib_qsfp_data *qd,
        dd->f_gpio_mod(dd, mask, mask, mask);
 }
 
-void qib_qsfp_deinit(struct qib_qsfp_data *qd)
-{
-       /*
-        * There is nothing to do here for now.  our work is scheduled
-        * with queue_work(), and flush_workqueue() from remove_one
-        * will block until all work setup with queue_work()
-        * completes.
-        */
-}
-
 int qib_qsfp_dump(struct qib_pportdata *ppd, char *buf, int len)
 {
        struct qib_qsfp_cache cd;
index 91908f533a2b00ef01fbb90a7fa3ac6d7c96dd6f..ad8dbd6ac0cf205d0be298ca1427378dea615936 100644 (file)
@@ -186,4 +186,3 @@ extern int qib_refresh_qsfp_cache(struct qib_pportdata *ppd,
 extern int qib_qsfp_mod_present(struct qib_pportdata *ppd);
 extern void qib_qsfp_init(struct qib_qsfp_data *qd,
                          void (*fevent)(struct work_struct *));
-extern void qib_qsfp_deinit(struct qib_qsfp_data *qd);