powerpc/mpic: Remove WHOAMI readback after EOI
authorBogdan Purcareata <bogdan.purcareata@freescale.com>
Tue, 24 Mar 2015 10:43:43 +0000 (10:43 +0000)
committerScott Wood <scottwood@freescale.com>
Wed, 1 Apr 2015 03:23:20 +0000 (22:23 -0500)
After previous discussions regarding the subject [1][2], there's no clear
explanation or reason why the call was needed in the first place. The sensible
argument is some sort of synchronization between the CPU and the MPIC, which
hasn't been pointed out precisely and is no longer required (at least on BookE
platforms).

The benefit of this change is saving a MMIO trap per interrupt when running in a
KVM guest.

[1] https://patchwork.ozlabs.org/patch/429098/
[2] https://patchwork.ozlabs.org/patch/433557/

Signed-off-by: Bogdan Purcareata <bogdan.purcareata@freescale.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
arch/powerpc/sysdev/mpic.c

index 2c817a736b7780c1c60a53413f267de11777f544..fb19084c586047cac03dfbb21dde3e5b240be92e 100644 (file)
@@ -655,7 +655,6 @@ static inline struct mpic * mpic_from_irq_data(struct irq_data *d)
 static inline void mpic_eoi(struct mpic *mpic)
 {
        mpic_cpu_write(MPIC_INFO(CPU_EOI), 0);
-       (void)mpic_cpu_read(MPIC_INFO(CPU_WHOAMI));
 }
 
 /*