greybus: interface: clean up error messages
authorJohan Hovold <johan@hovoldconsulting.com>
Mon, 7 Dec 2015 14:05:46 +0000 (15:05 +0100)
committerGreg Kroah-Hartman <gregkh@google.com>
Tue, 8 Dec 2015 20:56:38 +0000 (15:56 -0500)
Drop redundant __func__ and add missing errno values.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/interface.c

index 1c6a8a4ac4b5d68020320d69d014d96275cc32c2..85fcae76928ca813e9c70d9050891aa764b0cc6a 100644 (file)
@@ -179,8 +179,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id)
        /* Get manifest size using control protocol on CPort */
        size = gb_control_get_manifest_size_operation(intf);
        if (size <= 0) {
-               dev_err(&intf->dev, "%s: Failed to get manifest size (%d)\n",
-                       __func__, size);
+               dev_err(&intf->dev, "failed to get manifest size: %d\n", size);
                if (size)
                        return size;
                else
@@ -194,7 +193,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id)
        /* Get manifest using control protocol on CPort */
        ret = gb_control_get_manifest_operation(intf, manifest, size);
        if (ret) {
-               dev_err(&intf->dev, "%s: Failed to get manifest\n", __func__);
+               dev_err(&intf->dev, "failed to get manifest: %d\n", ret);
                goto free_manifest;
        }
 
@@ -203,7 +202,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id)
         * what's in it.
         */
        if (!gb_manifest_parse(intf, manifest, size)) {
-               dev_err(&intf->dev, "%s: Failed to parse manifest\n", __func__);
+               dev_err(&intf->dev, "failed to parse manifest\n");
                ret = -EINVAL;
                goto free_manifest;
        }