RDMA/mlx4: Fix create qp command alignment
authorMaor Gottlieb <maorg@mellanox.com>
Thu, 17 Aug 2017 12:50:35 +0000 (15:50 +0300)
committerDoug Ledford <dledford@redhat.com>
Thu, 24 Aug 2017 20:27:10 +0000 (16:27 -0400)
Avoid extra padding by replacing the order of inl_recv_sz and reserved,
otherwise 'mlx4_ib_create_qp' structure might be larger than legacy user
input leading to copy of some garbage data from the user space buffer.

Fixes: ea30b966f7dd ('IB/mlx4: Add inline-receive support')
Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
include/uapi/rdma/mlx4-abi.h

index d915cab37ec30a31e2d9f5ac56e46768c0e3e5d1..21cce1a4c4dd44b5cd64ee5b611d43dab232eb02 100644 (file)
@@ -111,8 +111,8 @@ struct mlx4_ib_create_qp {
        __u8    log_sq_bb_count;
        __u8    log_sq_stride;
        __u8    sq_no_prefetch;
-       __u32   inl_recv_sz;
        __u8    reserved;
+       __u32   inl_recv_sz;
 };
 
 struct mlx4_ib_create_wq {