net/ncsi: Don't probe on the reserved channel ID (0x1f)
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Tue, 4 Oct 2016 00:25:49 +0000 (11:25 +1100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Oct 2016 06:11:50 +0000 (02:11 -0400)
We needn't send CIS (Clear Initial State) command to the NCSI
reserved channel (0x1f) in the enumeration. We shouldn't receive
a valid response from CIS on NCSI channel 0x1f.

Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ncsi/ncsi-manage.c

index 97c99bee8b68a3efaa368de0f1af54235e122133..8c5e0160d578bb4a5dcf8c3e7d944cf090924a86 100644 (file)
@@ -911,12 +911,12 @@ static void ncsi_probe_channel(struct ncsi_dev_priv *ndp)
                nd->state = ncsi_dev_state_probe_cis;
                break;
        case ncsi_dev_state_probe_cis:
-               ndp->pending_req_num = 32;
+               ndp->pending_req_num = NCSI_RESERVED_CHANNEL;
 
                /* Clear initial state */
                nca.type = NCSI_PKT_CMD_CIS;
                nca.package = ndp->active_package->id;
-               for (index = 0; index < 0x20; index++) {
+               for (index = 0; index < NCSI_RESERVED_CHANNEL; index++) {
                        nca.channel = index;
                        ret = ncsi_xmit_cmd(&nca);
                        if (ret)