projects
/
GitHub
/
MotorolaMobilityLLC
/
kernel-slsi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5918e2f
)
fix return value of __pppoe_xmit() method.
author
Rami Rosen
<ramirose@gmail.com>
Thu, 3 Jun 2010 05:02:29 +0000
(
05:02
+0000)
committer
David S. Miller
<davem@davemloft.net>
Sat, 5 Jun 2010 09:23:15 +0000
(
02:23
-0700)
Hi,
__pppoe_xmit() in drivers/net/pppoe always returns 1.
When the methods fails (via goto abort), it should return 0 and not 1.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/pppoe.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/net/pppoe.c
b/drivers/net/pppoe.c
index 805b64d1e893564bfc7aa1b3957c1df606dcf46a..7ebb8e87efa4165e08552fce400e5f01c8de9ffd 100644
(file)
--- a/
drivers/net/pppoe.c
+++ b/
drivers/net/pppoe.c
@@
-949,7
+949,7
@@
static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb)
abort:
kfree_skb(skb);
- return
1
;
+ return
0
;
}
/************************************************************************