x86/mm/cpa: Add missing comment in populate_pdg()
authorAndy Lutomirski <luto@kernel.org>
Sat, 23 Jul 2016 16:59:28 +0000 (09:59 -0700)
committerIngo Molnar <mingo@kernel.org>
Sat, 23 Jul 2016 19:17:10 +0000 (21:17 +0200)
In commit:

  21cbc2822aa1 ("x86/mm/cpa: Unbreak populate_pgd(): stop trying to deallocate failed PUDs")

I intended to add this comment, but I failed at using git.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/242baf8612394f4e31216f96d13c4d2e9b90d1b7.1469293159.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/mm/pageattr.c

index 2bc6ea153f763793ddda06af489adcc3656b5249..47870a534877c59e0580c74f54095d6db0ccfc83 100644 (file)
@@ -1091,6 +1091,11 @@ static int populate_pgd(struct cpa_data *cpa, unsigned long addr)
 
        ret = populate_pud(cpa, addr, pgd_entry, pgprot);
        if (ret < 0) {
+               /*
+                * Leave the PUD page in place in case some other CPU or thread
+                * already found it, but remove any useless entries we just
+                * added to it.
+                */
                unmap_pud_range(pgd_entry, addr,
                                addr + (cpa->numpages << PAGE_SHIFT));
                return ret;