fs/proc/task_mmu.c: update m->version in the main loop in m_start()
authorOleg Nesterov <oleg@redhat.com>
Thu, 9 Oct 2014 22:25:43 +0000 (15:25 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 10 Oct 2014 02:25:49 +0000 (22:25 -0400)
Change the main loop in m_start() to update m->version. Mostly for
consistency, but this can help to avoid the same loop if the very
1st ->show() fails due to seq_overflow().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/task_mmu.c

index c7228c2326d106e15a64d8fc72bd3e2b215f1edc..34d93a1cdeec7409a3f01c35885cb86c8f69a52a 100644 (file)
@@ -184,11 +184,14 @@ static void *m_start(struct seq_file *m, loff_t *ppos)
 
        m->version = 0;
        if (pos < mm->map_count) {
-               for (vma = mm->mmap; pos; pos--)
+               for (vma = mm->mmap; pos; pos--) {
+                       m->version = vma->vm_start;
                        vma = vma->vm_next;
+               }
                return vma;
        }
 
+       /* we do not bother to update m->version in this case */
        if (pos == mm->map_count && priv->tail_vma)
                return priv->tail_vma;