regulator: da9063: Optimize da9063_set_current_limit implementation
authorAxel Lin <axel.lin@ingics.com>
Fri, 30 Aug 2013 12:07:38 +0000 (20:07 +0800)
committerMark Brown <broonie@linaro.org>
Fri, 30 Aug 2013 14:24:42 +0000 (15:24 +0100)
All the current limit tables have the values in ascend order.
So we can slightly optimize the for loop iteration because the first match
is the minimal value.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/da9063-regulator.c

index fc2871cb4742811a76d0235c6e5429d6be451a83..f29e7290cc94a8c0256dd2edd3580676301b43c9 100644 (file)
@@ -166,22 +166,15 @@ static int da9063_set_current_limit(struct regulator_dev *rdev,
 {
        struct da9063_regulator *regl = rdev_get_drvdata(rdev);
        const struct da9063_regulator_info *rinfo = regl->info;
-       int val = INT_MAX;
-       unsigned sel = 0;
-       int n;
-       int tval;
+       int n, tval;
 
        for (n = 0; n < rinfo->n_current_limits; n++) {
                tval = rinfo->current_limits[n];
-               if (tval >= min_uA && tval <= max_uA && val > tval) {
-                       val = tval;
-                       sel = n;
-               }
+               if (tval >= min_uA && tval <= max_uA)
+                       return regmap_field_write(regl->ilimit, n);
        }
-       if (val == INT_MAX)
-               return -EINVAL;
 
-       return regmap_field_write(regl->ilimit, sel);
+       return -EINVAL;
 }
 
 static int da9063_get_current_limit(struct regulator_dev *rdev)