phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages
authorPeter Griffin <peter.griffin@linaro.org>
Fri, 15 Aug 2014 12:40:13 +0000 (13:40 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 24 Sep 2014 09:48:32 +0000 (15:18 +0530)
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().

Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-spear1340-miphy.c

index 7135ba2603b6ef4dc6861fe92799132fa819368e..ee4d66f588e3a3a814c24376c83a7b6d2e328dd0 100644 (file)
@@ -249,10 +249,8 @@ static int spear1340_miphy_probe(struct platform_device *pdev)
        struct phy_provider *phy_provider;
 
        priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
-       if (!priv) {
-               dev_err(dev, "can't alloc spear1340_miphy private date memory\n");
+       if (!priv)
                return -ENOMEM;
-       }
 
        priv->misc =
                syscon_regmap_lookup_by_phandle(dev->of_node, "misc");