Drop wcf1_acp_session when upgrading from 5.3

diff --git a/com.woltlab.wcf/package.xml b/com.woltlab.wcf/package.xml
index c298504d93d5335e861cfdd3919c0104ef755060..9b472776af754782bbca8c8af59b0aea229e5e7f 100644 (file)
--- a/com.woltlab.wcf/package.xml
+++ b/com.woltlab.wcf/package.xml
@@ -81,7 +81,8 @@ tar cvf com.woltlab.wcf/files_pre.tar -C wcfsetup/install/files/ \
                
                <!-- Cleanup for the new session system. -->
                <instruction type="script" run="standalone">acp/update_com.woltlab.wcf_5.4_session_3_drop_virtual.php</instruction>
-               <instruction type="script" run="standalone">acp/update_com.woltlab.wcf_5.4_session_4_clean_session.php</instruction>
+               <instruction type="script" run="standalone">acp/update_com.woltlab.wcf_5.4_session_4_drop_acp.php</instruction>
+               <instruction type="script" run="standalone">acp/update_com.woltlab.wcf_5.4_session_5_clean_session.php</instruction>
                
                <!-- Non-critical database adjustments. -->
                <instruction type="script" run="standalone">acp/update_com.woltlab.wcf_5.4_db.php</instruction>

diff --git a/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_4_clean_session.php b/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_4_clean_session.php
deleted file mode 100644 (file)
index d036404..0000000
--- a/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_4_clean_session.php
+++ /dev/null
@@ -1,49 +0,0 @@
-<?php
-
-use wcf\system\database\table\column\MediumblobDatabaseTableColumn;
-use wcf\system\database\table\column\NotNullVarchar255DatabaseTableColumn;
-use wcf\system\database\table\column\VarcharDatabaseTableColumn;
-use wcf\system\database\table\DatabaseTableChangeProcessor;
-use wcf\system\database\table\index\DatabaseTableIndex;
-use wcf\system\database\table\PartialDatabaseTable;
-use wcf\system\WCF;
-
-/**
- * Adjusts wcf1_acp_session, wcf1_acp_session_access_log and wcf1_session.
- * 
- * @author     Tim Duesterhus
- * @copyright  2001-2020 WoltLab GmbH
- * @license    GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
- * @package    WoltLabSuite\Core
- */
-
-$tables = [
-       PartialDatabaseTable::create('wcf1_acp_session')
-               ->columns([
-                       VarcharDatabaseTableColumn::create('requestURI')->drop(),
-                       VarcharDatabaseTableColumn::create('requestMethod')->drop(),
-                       MediumblobDatabaseTableColumn::create('sessionVariables'),
-               ])
-               ->indices([
-                       DatabaseTableIndex::create()
-                               ->columns(['userID']),
-                       DatabaseTableIndex::create()
-                               ->columns(['lastActivityTime']),
-               ]),
-       PartialDatabaseTable::create('wcf1_acp_session_access_log')
-               ->columns([
-                       NotNullVarchar255DatabaseTableColumn::create('requestMethod')
-                               ->defaultValue(''),
-               ]),
-       PartialDatabaseTable::create('wcf1_session')
-               ->columns([
-                       MediumblobDatabaseTableColumn::create('sessionVariables')->drop(),
-               ]),
-];
-
-(new DatabaseTableChangeProcessor(
-/** @var ScriptPackageInstallationPlugin $this */
-       $this->installation->getPackage(),
-       $tables,
-       WCF::getDB()->getEditor())
-)->process();

diff --git a/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_4_drop_acp.php b/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_4_drop_acp.php
new file mode 100644 (file)
index 0000000..ced6934
--- /dev/null
+++ b/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_4_drop_acp.php
@@ -0,0 +1,26 @@
+<?php
+
+use wcf\system\database\table\DatabaseTableChangeProcessor;
+use wcf\system\database\table\PartialDatabaseTable;
+use wcf\system\WCF;
+
+/**
+ * Removes the wcf1_acp_session table.
+ * 
+ * @author     Tim Duesterhus
+ * @copyright  2001-2020 WoltLab GmbH
+ * @license    GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @package    WoltLabSuite\Core
+ */
+
+$tables = [
+       PartialDatabaseTable::create('wcf1_acp_session')
+               ->drop(),
+];
+
+(new DatabaseTableChangeProcessor(
+/** @var ScriptPackageInstallationPlugin $this */
+       $this->installation->getPackage(),
+       $tables,
+       WCF::getDB()->getEditor())
+)->process();

diff --git a/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_5_clean_session.php b/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_5_clean_session.php
new file mode 100644 (file)
index 0000000..e1f3e45
--- /dev/null
+++ b/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.4_session_5_clean_session.php
@@ -0,0 +1,37 @@
+<?php
+
+use wcf\system\database\table\column\MediumblobDatabaseTableColumn;
+use wcf\system\database\table\column\NotNullVarchar255DatabaseTableColumn;
+use wcf\system\database\table\column\VarcharDatabaseTableColumn;
+use wcf\system\database\table\DatabaseTableChangeProcessor;
+use wcf\system\database\table\index\DatabaseTableIndex;
+use wcf\system\database\table\PartialDatabaseTable;
+use wcf\system\WCF;
+
+/**
+ * Adjusts wcf1_acp_session_access_log and wcf1_session.
+ * 
+ * @author     Tim Duesterhus
+ * @copyright  2001-2020 WoltLab GmbH
+ * @license    GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @package    WoltLabSuite\Core
+ */
+
+$tables = [
+       PartialDatabaseTable::create('wcf1_acp_session_access_log')
+               ->columns([
+                       NotNullVarchar255DatabaseTableColumn::create('requestMethod')
+                               ->defaultValue(''),
+               ]),
+       PartialDatabaseTable::create('wcf1_session')
+               ->columns([
+                       MediumblobDatabaseTableColumn::create('sessionVariables')->drop(),
+               ]),
+];
+
+(new DatabaseTableChangeProcessor(
+/** @var ScriptPackageInstallationPlugin $this */
+       $this->installation->getPackage(),
+       $tables,
+       WCF::getDB()->getEditor())
+)->process();