ring_buffer: Remove unneeded smp_wmb() before wakeup of reader benchmark
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Tue, 3 Nov 2015 21:19:02 +0000 (16:19 -0500)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 3 Nov 2015 21:19:02 +0000 (16:19 -0500)
wake_up_process() has a memory barrier before doing anything, thus adding a
memory barrier before calling it is redundant.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/ring_buffer_benchmark.c

index 9e00fd17822657428f4ef71715ac8332acf9ee6a..6df9a83e20d7eb360a6e58eb2599a959326c6bcc 100644 (file)
@@ -288,8 +288,6 @@ static void ring_buffer_producer(void)
                /* the completions must be visible before the finish var */
                smp_wmb();
                reader_finish = 1;
-               /* finish var visible before waking up the consumer */
-               smp_wmb();
                wake_up_process(consumer);
                wait_for_completion(&read_done);
        }