tty: audit: remove unused variable
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Wed, 24 Feb 2016 11:15:09 +0000 (16:45 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Mar 2016 00:11:14 +0000 (16:11 -0800)
While building with W=1 we were getting build warning:
drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used

The local variable sessionid was only assigned the value of
current->sessionid but was never reused. On further inspection it turned
out that there is no need of audit_get_loginuid() also.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_audit.c

index 66d53fcf4da0d8616265e39e96239f47d2398e90..df2d735338e216d0a398c50a7e4202afd21417e6 100644 (file)
@@ -144,14 +144,8 @@ void tty_audit_tiocsti(struct tty_struct *tty, char ch)
        if (tty_audit_push())
                return;
 
-       if (audit_enabled) {
-               kuid_t auid;
-               unsigned int sessionid;
-
-               auid = audit_get_loginuid(current);
-               sessionid = audit_get_sessionid(current);
+       if (audit_enabled)
                tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1);
-       }
 }
 
 /**