net: cdc_ncm: log signatures in hex
authorBjørn Mork <bjorn@mork.no>
Fri, 1 Nov 2013 10:16:55 +0000 (11:16 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Nov 2013 06:02:04 +0000 (02:02 -0400)
These signatures are well known bit patterns, mostly made up
of ascii characters.  Mentally parsing works best if they
are printed in hex.

Cc: Alexey Orishko <alexey.orishko@gmail.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_ncm.c

index 73faf05209b3c1f8aaeb44bff88eb74d379cc172..d49e4c5b292a49e0ca6560664c3509ce2a99cdcf 100644 (file)
@@ -883,8 +883,9 @@ int cdc_ncm_rx_verify_nth16(struct cdc_ncm_ctx *ctx, struct sk_buff *skb_in)
        nth16 = (struct usb_cdc_ncm_nth16 *)skb_in->data;
 
        if (le32_to_cpu(nth16->dwSignature) != USB_CDC_NCM_NTH16_SIGN) {
-               pr_debug("invalid NTH16 signature <%u>\n",
-                                       le32_to_cpu(nth16->dwSignature));
+               netif_dbg(dev, rx_err, dev->net,
+                         "invalid NTH16 signature <%#010x>\n",
+                         le32_to_cpu(nth16->dwSignature));
                goto error;
        }
 
@@ -972,8 +973,9 @@ next_ndp:
        ndp16 = (struct usb_cdc_ncm_ndp16 *)(skb_in->data + ndpoffset);
 
        if (le32_to_cpu(ndp16->dwSignature) != USB_CDC_NCM_NDP16_NOCRC_SIGN) {
-               pr_debug("invalid DPT16 signature <%u>\n",
-                        le32_to_cpu(ndp16->dwSignature));
+               netif_dbg(dev, rx_err, dev->net,
+                         "invalid DPT16 signature <%#010x>\n",
+                         le32_to_cpu(ndp16->dwSignature));
                goto err_ndp;
        }
        dpe16 = ndp16->dpe16;