staging: dgap: dgap_tty: Do not use 0 for pointers
authorSachin Kamat <sachin.kamat@linaro.org>
Wed, 9 Oct 2013 10:28:25 +0000 (15:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Oct 2013 22:36:30 +0000 (15:36 -0700)
0 should not be used instead of NULL for pointers.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgap/dgap_tty.c

index 924e2bfcbe3069930ef48dbb581a602a1b4df58d..2a7a37298da4456ddbcab91a81b7cb6d407d5dcd 100644 (file)
@@ -595,7 +595,7 @@ static void dgap_sniff_nowait_nolock(struct channel_t *ch, uchar *text, uchar *b
                /*
                 *  Loop while data remains.
                 */
-               while (nbuf > 0 && ch->ch_sniff_buf != 0) {
+               while (nbuf > 0 && ch->ch_sniff_buf) {
                        /*
                         *  Determine the amount of available space left in the
                         *  buffer.  If there's none, wait until some appears.
@@ -1107,9 +1107,10 @@ static int dgap_tty_open(struct tty_struct *tty, struct file *file)
                MAJOR(tty_devnum(tty)), MINOR(tty_devnum(tty)), un, brd->name));
 
        /*
-        * Error if channel info pointer is 0.
+        * Error if channel info pointer is NULL.
         */
-       if ((bs = ch->ch_bs) == 0) {
+       bs = ch->ch_bs;
+       if (!bs) {
                DGAP_UNLOCK(ch->ch_lock, lock_flags2);
                DGAP_UNLOCK(brd->bd_lock, lock_flags);
                DPR_OPEN(("%d BS is 0!\n", __LINE__));