usb: gadget: udc: add null check before pointer dereference
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Tue, 2 May 2017 16:37:22 +0000 (11:37 -0500)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 17 May 2017 11:16:20 +0000 (14:16 +0300)
Add null check before dereferencing dev->regs pointer inside
net2280_led_shutdown() function.

Addresses-Coverity-ID: 101783
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/net2280.c

index 6cf07857eacaa19b873b18c299079fd07507a5cf..29c3d11a0e1d1eefab8ed3acfb383aa6450fd431 100644 (file)
@@ -3573,7 +3573,6 @@ static void net2280_remove(struct pci_dev *pdev)
        BUG_ON(dev->driver);
 
        /* then clean up the resources we allocated during probe() */
-       net2280_led_shutdown(dev);
        if (dev->requests) {
                int             i;
                for (i = 1; i < 5; i++) {
@@ -3588,8 +3587,10 @@ static void net2280_remove(struct pci_dev *pdev)
                free_irq(pdev->irq, dev);
        if (dev->quirks & PLX_PCIE)
                pci_disable_msi(pdev);
-       if (dev->regs)
+       if (dev->regs) {
+               net2280_led_shutdown(dev);
                iounmap(dev->regs);
+       }
        if (dev->region)
                release_mem_region(pci_resource_start(pdev, 0),
                                pci_resource_len(pdev, 0));