drm: rcar-du: Remove unneeded rcar_du_crtc plane field
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 23 Feb 2015 01:20:39 +0000 (03:20 +0200)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 3 Mar 2015 14:16:26 +0000 (16:16 +0200)
The rcar_du_crtc plane field is only used to check for an error that
can't occur. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
drivers/gpu/drm/rcar-du/rcar_du_crtc.c
drivers/gpu/drm/rcar-du/rcar_du_crtc.h

index 3f64707412e6fd27733029bb46f14153a40988e2..c70f730360568af3ab5dc4b11a99fc5b443d7e66 100644 (file)
@@ -353,9 +353,6 @@ static void rcar_du_crtc_start(struct rcar_du_crtc *rcrtc)
        if (rcrtc->started)
                return;
 
-       if (WARN_ON(rcrtc->plane->format == NULL))
-               return;
-
        /* Set display off and background to black */
        rcar_du_crtc_write(rcrtc, DOOR, DOOR_RGB(0, 0, 0));
        rcar_du_crtc_write(rcrtc, BPOR, BPOR_RGB(0, 0, 0));
@@ -606,9 +603,9 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index)
        rcrtc->mmio_offset = mmio_offsets[index];
        rcrtc->index = index;
        rcrtc->enabled = false;
-       rcrtc->plane = &rgrp->planes.planes[index % 2];
 
-       ret = drm_crtc_init_with_planes(rcdu->ddev, crtc, &rcrtc->plane->plane,
+       ret = drm_crtc_init_with_planes(rcdu->ddev, crtc,
+                                       &rgrp->planes.planes[index % 2].plane,
                                        NULL, &crtc_funcs);
        if (ret < 0)
                return ret;
index 0a3dcca58fd7276c79b33de95375521eb3f92711..5d9aa9b33769eb225ea3919d2fc7f06842988f6f 100644 (file)
@@ -21,7 +21,6 @@
 #include <drm/drm_crtc.h>
 
 struct rcar_du_group;
-struct rcar_du_plane;
 
 struct rcar_du_crtc {
        struct drm_crtc crtc;
@@ -39,7 +38,6 @@ struct rcar_du_crtc {
        bool enabled;
 
        struct rcar_du_group *group;
-       struct rcar_du_plane *plane;
 };
 
 #define to_rcar_crtc(c)        container_of(c, struct rcar_du_crtc, crtc)