of: Change of_device_is_available() to return bool

This function can only return true or false; using a bool makes it more
obvious to the reader.

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 4627e0acf4ad20695e2d1e69ca0b3ace6d5b52e0..2d5dfb8b2e658c2a24f61d26e61ac91bd3410364 100644 (file)
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -522,27 +522,27 @@ EXPORT_SYMBOL(of_machine_is_compatible);
  *
  *  @device: Node to check for availability, with locks already held
  *
- *  Returns 1 if the status property is absent or set to "okay" or "ok",
- *  0 otherwise
+ *  Returns true if the status property is absent or set to "okay" or "ok",
+ *  false otherwise
  */
-static int __of_device_is_available(const struct device_node *device)
+static bool __of_device_is_available(const struct device_node *device)
 {
        const char *status;
        int statlen;
 
        if (!device)
-               return 0;
+               return false;
 
        status = __of_get_property(device, "status", &statlen);
        if (status == NULL)
-               return 1;
+               return true;
 
        if (statlen > 0) {
                if (!strcmp(status, "okay") || !strcmp(status, "ok"))
-                       return 1;
+                       return true;
        }
 
-       return 0;
+       return false;
 }
 
 /**
@@ -550,13 +550,13 @@ static int __of_device_is_available(const struct device_node *device)
  *
  *  @device: Node to check for availability
  *
- *  Returns 1 if the status property is absent or set to "okay" or "ok",
- *  0 otherwise
+ *  Returns true if the status property is absent or set to "okay" or "ok",
+ *  false otherwise
  */
-int of_device_is_available(const struct device_node *device)
+bool of_device_is_available(const struct device_node *device)
 {
        unsigned long flags;
-       int res;
+       bool res;
 
        raw_spin_lock_irqsave(&devtree_lock, flags);
        res = __of_device_is_available(device);

diff --git a/include/linux/of.h b/include/linux/of.h
index 3c851a8f23eb57bdf44e3b2286434bd809260a28..27635c89d8c2490ad9776435642ba3468fc15f5e 100644 (file)
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -276,7 +276,7 @@ extern int of_property_read_string_helper(struct device_node *np,
                                              const char **out_strs, size_t sz, int index);
 extern int of_device_is_compatible(const struct device_node *device,
                                   const char *);
-extern int of_device_is_available(const struct device_node *device);
+extern bool of_device_is_available(const struct device_node *device);
 extern const void *of_get_property(const struct device_node *node,
                                const char *name,
                                int *lenp);
@@ -427,9 +427,9 @@ static inline int of_device_is_compatible(const struct device_node *device,
        return 0;
 }
 
-static inline int of_device_is_available(const struct device_node *device)
+static inline bool of_device_is_available(const struct device_node *device)
 {
-       return 0;
+       return false;
 }
 
 static inline struct property *of_find_property(const struct device_node *np,