configfs: Fix bool initialization/comparison
authorThomas Meyer <thomas@m3y3r.de>
Sat, 7 Oct 2017 14:02:21 +0000 (16:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Nov 2019 18:15:48 +0000 (19:15 +0100)
commit 3f6928c347707a65cee10a9f54b85ad5fb078b3f upstream.

Bool initializations should use true and false. Bool tests don't need
comparisons.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/configfs/file.c

index 2c6312db85168050f6ee35d0e82465d994e7a1ea..39bac169f915a37348cf06e944e4c1a825d4fa21 100644 (file)
@@ -166,7 +166,7 @@ configfs_read_bin_file(struct file *file, char __user *buf,
                retval = -ETXTBSY;
                goto out;
        }
-       buffer->read_in_progress = 1;
+       buffer->read_in_progress = true;
 
        if (buffer->needs_read_fill) {
                /* perform first read with buf == NULL to get extent */
@@ -325,7 +325,7 @@ configfs_write_bin_file(struct file *file, const char __user *buf,
                len = -ETXTBSY;
                goto out;
        }
-       buffer->write_in_progress = 1;
+       buffer->write_in_progress = true;
 
        /* buffer grows? */
        if (*ppos + count > buffer->bin_buffer_size) {
@@ -429,8 +429,8 @@ static int check_perm(struct inode * inode, struct file * file, int type)
        }
        mutex_init(&buffer->mutex);
        buffer->needs_read_fill = 1;
-       buffer->read_in_progress = 0;
-       buffer->write_in_progress = 0;
+       buffer->read_in_progress = false;
+       buffer->write_in_progress = false;
        buffer->ops = ops;
        file->private_data = buffer;
        goto Done;
@@ -488,10 +488,10 @@ static int configfs_release_bin_file(struct inode *inode, struct file *filp)
        ssize_t len = 0;
        int ret;
 
-       buffer->read_in_progress = 0;
+       buffer->read_in_progress = false;
 
        if (buffer->write_in_progress) {
-               buffer->write_in_progress = 0;
+               buffer->write_in_progress = false;
 
                len = bin_attr->write(item, buffer->bin_buffer,
                                buffer->bin_buffer_size);