Make SessionHandler::keepAlive() a no-op

diff --git a/wcfsetup/install/files/lib/data/session/SessionAction.class.php b/wcfsetup/install/files/lib/data/session/SessionAction.class.php
index 3bc04b57d7a68780e66f57a831d82361d433772c..071607fad7867547f59e62db1fc86ca853a74506 100644 (file)
--- a/wcfsetup/install/files/lib/data/session/SessionAction.class.php
+++ b/wcfsetup/install/files/lib/data/session/SessionAction.class.php
@@ -55,9 +55,6 @@ class SessionAction extends AbstractDatabaseObjectAction {
                        return [];
                }
                
-               // update last activity time
-               SessionHandler::getInstance()->keepAlive();
-               
                // update notification counts
                $this->keepAliveData = [
                        'userNotificationCount' => UserNotificationHandler::getInstance()->getNotificationCount(true)

diff --git a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
index b6dd40b11063ca87dce8bb564edb5621188d92af..afbb1582b808abdcdbb65cd901c03570ff965f9b 100644 (file)
--- a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
+++ b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
@@ -742,18 +742,9 @@ final class SessionHandler extends SingletonFactory {
        }
        
        /**
-        * Updates last activity time to protect session from expiring.
+        * @deprecated 5.4 - This method is a noop. The lastActivityTime is always updated immediately after loading.
         */
-       public function keepAlive() {
-               $this->disableUpdate();
-               
-               // update last activity time
-               /** @var \wcf\data\DatabaseObjectEditor $sessionEditor */
-               $sessionEditor = new $this->sessionEditorClassName($this->session);
-               $sessionEditor->update([
-                       'lastActivityTime' => TIME_NOW
-               ]);
-       }
+       public function keepAlive() { }
        
        /**
         * Deletes this session and its related data.