ext4: remove a duplicate call in ext4_init_new_dir()
authorWang Shilong <wshilong@ddn.com>
Sat, 30 Aug 2014 03:20:44 +0000 (23:20 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 30 Aug 2014 03:20:44 +0000 (23:20 -0400)
ext4_journal_get_write_access() has just been called in ext4_append()
calling it again here is duplicated.

Signed-off-by: Wang Shilong <wshilong@ddn.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/namei.c

index dec92b675b353e7fd5c2e02061d6a8d32bfdc861..51705f8c411612cae937cbf56c8488ebab662cee 100644 (file)
@@ -2378,10 +2378,6 @@ static int ext4_init_new_dir(handle_t *handle, struct inode *dir,
        dir_block = ext4_append(handle, inode, &block);
        if (IS_ERR(dir_block))
                return PTR_ERR(dir_block);
-       BUFFER_TRACE(dir_block, "get_write_access");
-       err = ext4_journal_get_write_access(handle, dir_block);
-       if (err)
-               goto out;
        de = (struct ext4_dir_entry_2 *)dir_block->b_data;
        ext4_init_dot_dotdot(inode, de, blocksize, csum_size, dir->i_ino, 0);
        set_nlink(inode, 2);