ARM: at91: PIT: Follow the general coding rules
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Tue, 1 Jul 2014 09:33:14 +0000 (11:33 +0200)
committerNicolas Ferre <nicolas.ferre@atmel.com>
Tue, 2 Sep 2014 16:52:02 +0000 (18:52 +0200)
Replace all masks and bits definitions by matching calls to BIT and GENMASK.
While we're at it, also fix a few style issues.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
arch/arm/mach-at91/at91sam926x_time.c

index 0a9e2fc8f7968996fcd5d994e4e797eaac76ea3d..fd3170b65fbb8b976171c106cb2bdd3486f90f0c 100644 (file)
@@ -9,11 +9,12 @@
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
  */
+
+#include <linux/clk.h>
+#include <linux/clockchips.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
 #include <linux/kernel.h>
-#include <linux/clk.h>
-#include <linux/clockchips.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <mach/hardware.h>
 
 #define AT91_PIT_MR            0x00                    /* Mode Register */
-#define                AT91_PIT_PITIEN         (1 << 25)               /* Timer Interrupt Enable */
-#define                AT91_PIT_PITEN          (1 << 24)               /* Timer Enabled */
-#define                AT91_PIT_PIV            (0xfffff)               /* Periodic Interval Value */
+#define AT91_PIT_PITIEN                        BIT(25)                 /* Timer Interrupt Enable */
+#define AT91_PIT_PITEN                 BIT(24)                 /* Timer Enabled */
+#define AT91_PIT_PIV                   GENMASK(19, 0)          /* Periodic Interval Value */
 
 #define AT91_PIT_SR            0x04                    /* Status Register */
-#define                AT91_PIT_PITS           (1 << 0)                /* Timer Status */
+#define AT91_PIT_PITS                  BIT(0)                  /* Timer Status */
 
 #define AT91_PIT_PIVR          0x08                    /* Periodic Interval Value Register */
 #define AT91_PIT_PIIR          0x0c                    /* Periodic Interval Image Register */
-#define                AT91_PIT_PICNT          (0xfff << 20)           /* Interval Counter */
-#define                AT91_PIT_CPIV           (0xfffff)               /* Inverval Value */
+#define AT91_PIT_PICNT                 GENMASK(31, 20)         /* Interval Counter */
+#define AT91_PIT_CPIV                  GENMASK(19, 0)          /* Inverval Value */
 
 #define PIT_CPIV(x)    ((x) & AT91_PIT_CPIV)
 #define PIT_PICNT(x)   (((x) & AT91_PIT_PICNT) >> 20)