USB: xhci: Fix scratchpad deallocation.
authorSarah Sharp <sarah.a.sharp@linux.intel.com>
Wed, 4 Nov 2009 19:22:19 +0000 (11:22 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 18 Nov 2009 00:46:34 +0000 (16:46 -0800)
The scratchpad_free() function uses xhci->page_size to free some memory
with pci_free_consistent().  However, the page_size is set to zero before
the call, causing kernel oopses on driver unload.  Call scratchpad_free()
before setting xhci->page_size to zero.

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Acked-by: John Youn <John.Youn@synopsys.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/xhci-mem.c

index 732580c6cbea398fa58c7f9949fac626a12b9e44..b8fd270a8b0d5f2630ed87dbcf6d24f8a566c86e 100644 (file)
@@ -843,9 +843,9 @@ void xhci_mem_cleanup(struct xhci_hcd *xhci)
                                xhci->dcbaa, xhci->dcbaa->dma);
        xhci->dcbaa = NULL;
 
+       scratchpad_free(xhci);
        xhci->page_size = 0;
        xhci->page_shift = 0;
-       scratchpad_free(xhci);
 }
 
 int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)