locks: kill redundant local variable
authorJ. Bruce Fields <bfields@fieldses.org>
Tue, 14 Nov 2006 21:54:36 +0000 (16:54 -0500)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Tue, 9 Oct 2007 22:32:45 +0000 (18:32 -0400)
There's no need for another variable local to this loop; we can use the
variable (of the same name!) already declared at the top of the function,
and not used till later (at which point it's initialized, so this is safe).

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/locks.c

index 51bae6227c25fe409df65ebd1157a608c2ae8075..efe1affe6bed2754f3daf0fdbec37aea27d2be71 100644 (file)
@@ -819,7 +819,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
        lock_kernel();
        if (request->fl_type != F_UNLCK) {
                for_each_lock(inode, before) {
-                       struct file_lock *fl = *before;
+                       fl = *before;
                        if (!IS_POSIX(fl))
                                continue;
                        if (!posix_locks_conflict(request, fl))