ASoC: rt5670: Remove unbalanced pm_runtime_put()
authorHans de Goede <hdegoede@redhat.com>
Tue, 13 Dec 2022 12:33:19 +0000 (13:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jan 2023 11:07:34 +0000 (12:07 +0100)
[ Upstream commit 6c900dcc3f7331a67ed29739d74524e428d137fb ]

For some reason rt5670_i2c_probe() does a pm_runtime_put() at the end
of a successful probe. But it has never done a pm_runtime_get() leading
to the following error being logged into dmesg:

 rt5670 i2c-10EC5640:00: Runtime PM usage count underflow!

Fix this by removing the unnecessary pm_runtime_put().

Fixes: 64e89e5f5548 ("ASoC: rt5670: Add runtime PM support")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20221213123319.11285-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/rt5670.c

index fdc14e50d3b914fdac1066d016a329d09cec07cf..13b944bcde719ffd53ff19439165e5ea03dcafa1 100644 (file)
@@ -3028,8 +3028,6 @@ static int rt5670_i2c_probe(struct i2c_client *i2c,
        if (ret < 0)
                goto err;
 
-       pm_runtime_put(&i2c->dev);
-
        return 0;
 err:
        pm_runtime_disable(&i2c->dev);