sched: Fix strncmp operation
authorHillf Danton <dhillf@gmail.com>
Thu, 6 Jan 2011 12:58:12 +0000 (20:58 +0800)
committerIngo Molnar <mingo@elte.hu>
Fri, 7 Jan 2011 14:55:10 +0000 (15:55 +0100)
One of the operands, buf, is incorrect, since it is stripped and the
correct address for subsequent string comparing could change if
leading white spaces, if any, are removed from buf.

It is fixed by replacing buf with cmp.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <AANLkTinOPuYsVovrZpbuCCmG5deEyc8WgA_A1RJx_YK7@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c

index a8478a217deeb980505896191cc32734f9545dbf..a0eb0941fa84a1e1b194ac8d4e071aaec82183fb 100644 (file)
@@ -741,7 +741,7 @@ sched_feat_write(struct file *filp, const char __user *ubuf,
        buf[cnt] = 0;
        cmp = strstrip(buf);
 
-       if (strncmp(buf, "NO_", 3) == 0) {
+       if (strncmp(cmp, "NO_", 3) == 0) {
                neg = 1;
                cmp += 3;
        }