ASoC: wm8731: harmless underflow in wm8731_put_deemph()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Oct 2015 07:08:57 +0000 (10:08 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 22 Oct 2015 12:55:23 +0000 (13:55 +0100)
The code tries to verify that "deemph" is zero or one, but it fails to
account for that it can be negative.  It's harmless because negatives
are treated the same as one, but we should fix it just to silence the
static checker warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8731.c

index ace8645245a0c1765bde0d516a4a1067dec2a755..07cf1bd7913a8dfe4667e310fcb44536f8e4004c 100644 (file)
@@ -132,7 +132,7 @@ static int wm8731_put_deemph(struct snd_kcontrol *kcontrol,
 {
        struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
        struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
-       int deemph = ucontrol->value.integer.value[0];
+       unsigned int deemph = ucontrol->value.integer.value[0];
        int ret = 0;
 
        if (deemph > 1)